fix: correct baseapi of docxtopdf and decryptpdf#1803
Merged
prafull-opensignlabs merged 1 commit intostagingfrom Jun 18, 2025
Merged
fix: correct baseapi of docxtopdf and decryptpdf#1803prafull-opensignlabs merged 1 commit intostagingfrom
prafull-opensignlabs merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors URL construction by replacing direct string manipulation with a dedicated utility function, removeTrailingSegment, to improve consistency in handling trailing URL segments. Additionally, it updates both the Form.jsx and Utils.jsx files to adopt this new approach and adds accompanying JSDoc comments to document the utility function.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/OpenSign/src/pages/Form.jsx | Updates URL formation for the docxtopdf conversion by using removeTrailingSegment. |
| apps/OpenSign/src/constant/Utils.jsx | Adds the new removeTrailingSegment function and updates decryptPdf URL formation accordingly. |
Comments suppressed due to low confidence (1)
apps/OpenSign/src/constant/Utils.jsx:109
- [nitpick] Consider replacing the typographic quotes with standard double quotes for consistency and clarity in the documentation comments.
// Normalize a trailing slash (e.g. “/app/” → “/app”)
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.