[Possible Bug]: Hardcoded env values in runmigrate

[wafflesrg00d]

OpenSign/apps/OpenSignServer/runmigrate.js

Line 6 in e50f062

// `APPLICATION_ID=${process.env.APP_ID} SERVER_URL=${process.env.SERVER_URL} MASTER_KEY=${process.env.MASTER_KEY} npx parse-dbtool migrate`;

Why is Line 6 commented out vs. Line 5? I ran into the below error when running the project locally, this hardcoded line was the culprit.

OpenSignServer-container | ParseError: XMLHttpRequest failed: "Unable to connect to the Parse API"

I noticed this error mentioned in #559, as well.

[andrew-opensignlabs]

@prafull-opensignlabs can you please look into this?

[prafull-opensignlabs]

@wafflesrg00d Thank you for pointing out this file. However, it is not used anywhere; it was mistakenly pushed by the developer and will be removed in an upcoming update. The migration code is available in the index.js file.

[jsonpj3wt]

Hey @prafull-opensignlabs if that is not the code, then when is npx parse-dbtool migrate being called? It is the hardcoded values too during docker compose just like thot line and will fail because it doesn't match the .env that is copied.

[prafull-opensignlabs]

hey @jsonpj3wt Check the index.js file. There you will see the code for parse-dbtool migrate, where I have provided environment variables that get replaced at the time of execution. This is why you see actual values in the migration command, which might make it seem like there are hardcoded values.

[jsonpj3wt]

@prafull-opensignlabs ok great! Thank you!

[jsonpj3wt]

I did have one more question on that, and I don't mind creating the merge request if needed, but since the .env does have the server URL, could we have it where that env var is used vs http://localhost:8080/app? There may be a problem with that, since if you set it to 127.0.0.1:8080/app, docker will likely not be too happy, but with that change we could change the port used, which is something that would cause us issues if we have other containers running and using that port.