Fix OpenFlow version negotiation#6
Merged
alnvdl merged 2 commits intoOpenNetworkingFoundation:0.2from Nov 20, 2015
Merged
Conversation
The maximum version reported by the switch was always being used, as a result if the libfluid application did not support this version the negotiation would fail. E.g. A switch supporting 1.0,1.3 and a controller supporting only 1.0 would fail rather than selecting version 1.0. Now the highest version supported by both switch and controller is selected as per the OpenFlow standard.
…connection Only error messages during the handshake should close the connection
Member
|
Thanks for catching this! It'll take me a while to test it, but it looks good. And your approach also seems to make the version negotiation algorithm clearer. |
alnvdl
added a commit
that referenced
this pull request
Nov 20, 2015
Fix OpenFlow version negotiation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum version reported by the switch was always being used,
as a result if the libfluid application did not support this
version the negotiation would fail.
E.g. A switch supporting 1.0,1.3 and a controller supporting only 1.0
would fail rather than selecting version 1.0.
Now the highest version supported by both switch and controller is
selected as per the OpenFlow standard.