Skip to content

Comments

(A001) Simplify workflow for unittests#411

Merged
adeas31 merged 3 commits intoOpenModelica:masterfrom
syntron:simplify_workflow_Test
Feb 24, 2026
Merged

(A001) Simplify workflow for unittests#411
adeas31 merged 3 commits intoOpenModelica:masterfrom
syntron:simplify_workflow_Test

Conversation

@syntron
Copy link
Contributor

@syntron syntron commented Feb 18, 2026

simplify main test workflow - do not run test_FMIRegression

  • these are test for OpenModelica / no specific check for OMPython
  • they are run via a cron job
  • it increases the runtime of the unittest job

furthermore add a test workflow which runs only the latest version (unittests in ./tests) - needed later if data for v400 is defined

see PR #404

@adeas31
Copy link
Member

adeas31 commented Feb 19, 2026

simplify main test workflow - do not run test_FMIRegression

  • these are test for OpenModelica / no specific check for OMPython
  • they are run via a cron job
  • it increases the runtime of the unittest job

I agree these are more OpenModelica tests. I suggest we remove this test and its workflow completely. OMPython has no benefit having it.

furthermore add a test workflow which runs only the latest version (unittests in ./tests) -

Why is this workflow needed? Perhaps

needed later if data for v400 is defined

Better to add it when its required. Here its inclusion is not clear.

@syntron
Copy link
Contributor Author

syntron commented Feb 19, 2026

I agree these are more OpenModelica tests. I suggest we remove this test and its workflow completely. OMPython has no benefit having it.

OK; remove it completly (also the definiton using a cron job) or just deactivate the automated run such that it can be executed if needed?

Better to add it when its required. Here its inclusion is not clear.

OK; will remove it here. The idea was to be able to run both options v4xx and v400 separatly ...

@adeas31
Copy link
Member

adeas31 commented Feb 23, 2026

I agree these are more OpenModelica tests. I suggest we remove this test and its workflow completely. OMPython has no benefit having it.

OK; remove it completly (also the definiton using a cron job) or just deactivate the automated run such that it can be executed if needed?

Remove it completely. We already test this as part of our library testing.
https://libraries.openmodelica.org/branches/overview-fmi.html
https://libraries.openmodelica.org/branches/master-fmi/Modelica_4.1.0/Modelica_4.1.0.html

* these are test for OpenModelica / no specific check for OMPython
* they are run via a cron job
* it increases the runtime of the unittest job
@syntron syntron force-pushed the simplify_workflow_Test branch from d35a8ba to bb5df2b Compare February 23, 2026 20:00
@syntron
Copy link
Contributor Author

syntron commented Feb 23, 2026

@adeas31 Updated PR; only change is the removal of the test

@adeas31
Copy link
Member

adeas31 commented Feb 24, 2026

Remove the FMI Test link from the README.

@adeas31 adeas31 enabled auto-merge (squash) February 24, 2026 21:22
@adeas31 adeas31 merged commit 59d2ae6 into OpenModelica:master Feb 24, 2026
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants