Closed
Conversation
syntron
force-pushed
the
test
branch
4 times, most recently
from
0389dfe to
1712a85
Compare
Contributor
|
@syntron Just a note: it is easy to run tests locally: When you push a commit to this pull request, it has to create a new virtual machine, install all dependencies in it, and then run the tests and delete the VM. And it does this for two versions of python and for both linux and Windows. If you run tests locally, you won't have to wait as long for them to finish. |
Contributor
Author
|
@ondras12345 thanks for the hint; the problem is that I'm limited due to the distribution I use: no package for opensuse available ... thus, I have to run testing on a different computer (or on github) |
…ases there are a lot of functions which check the type of the input; this is done by if ... elif ... - however, invalid input is not catched, i.e. there is *NO* return value define (would be None) if the input is not matching any of the if branches
Rule: fail early, fail hard - tell the user that something is wrong! In this case, the user ask for the solution but could get None (= plain 'return') - this would case hard to track errors later (if verbose==False and raiseerrors==False)
* fix ex.message => ex.msg
needs the preparation / additional changes in OMCSession* and ModelicaSystem
this is handled in OMCSessionZMQ.sendExpression()
could be a simulation which stoped before the final time ...
./OMPython/ModelicaSystem.py:1236:72: E999 SyntaxError: f-string: unmatched '['
Contributor
Author
|
this draft PR is (kind of) ready ... I will split it in smaller parts; however, as there are dependencies between the elements some PR will depend on each other ... |
This was referenced Apr 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a draft of ideas to further work on ...
... will be splitted into separate PRs if ready ...