fix(security): prevent path traversal in virtual host web hosting handler#2204
Closed
fix(security): prevent path traversal in virtual host web hosting handler#2204
Conversation
6 tasks
…t request handler Co-authored-by: PIKACHUIM <40362270+PIKACHUIM@users.noreply.github.com>
Co-authored-by: PIKACHUIM <40362270+PIKACHUIM@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on virtual host support implementation
fix(security): prevent path traversal in virtual host web hosting handler
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleWebHostingpassedc.Request.URL.Pathdirectly topath.Join(vhost.Path, reqPath), allowing a crafted request like/../../../etc/passwdto escape the virtual host root and traverse into arbitrary filesystem paths viainternalfs.Get/Link.Changes
/withstrings.TrimPrefixto force a relative path, thenstdpath.Cleanto resolve any../.components..(escapes root) or/(absolute path injection) before joining withvhost.Path.htmlfallback: Applied the same sanitizedcleanedRelto the<path>.htmlfallback path, which was also using the rawreqPathAttack example blocked:
/../../../etc/passwd→ after stripping/,Clean("../../../etc/passwd")="../../../etc/passwd"→ rejected byHasPrefix(cleanedRel, "../").🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.