[Java] Replace if with ? in Generated toIndentedString-methods#23209
[Java] Replace if with ? in Generated toIndentedString-methods#23209wing328 merged 22 commits intoOpenAPITools:masterfrom
if with ? in Generated toIndentedString-methods#23209Conversation
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
|
Only ran |
|
On second thought, wouldn't it just be simpler with |
…String`-methods Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
|
To be completely honest, I don't know if these methods should even be kept at all... that's a lot of boilerplate just to make the output prettier... |
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
toIndentedString-method to use String::valueOftoIndentedString-methods to Use Ternary Operators Instead of ifs
toIndentedString-methods to Use Ternary Operators Instead of ifsif with ? in Generated toIndentedString-methods
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
|
Ready for review, is this something you could review @wing328 ? 🙌 |
|
or perhaps @jpfinne could have a look? |
|
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
|
cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) |
|
thanks for the PR i'm ok with using a single-line ternary null check instead. let's give it a try |
Refactors all generated Java classes'
toIndentedString-method to internally use Ternary Operator for null-checking, instead of a conventionalif-statement.NOTE: This change should make the method smaller, but will be equivalent in terms of functionality and performance.
Example:
Before:
After:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Refactor
toIndentedStringacross all Java templates to use a single-line ternary null check and regenerate samples across Java generators. Behavior is unchanged ("null" for null;toString()with newline indentation otherwise).Written for commit 2909915. Summary will update on new commits.