Open
Conversation
Replace pull_request_target with pull_request to prevent duplicate workflow runs when merging PRs to master. Previously, merging a PR fired both 'push' and 'pull_request_target' simultaneously, causing two runs to race for the gh-pages force-push. The loser failed with a "cannot lock ref" error. With pull_request, only the push event deploys on merge, while PRs still get build-tested.
For pull_request events, github.ref_name resolves to the merge ref (e.g. "21/merge") instead of a real branch name. This caused sphinx-versioned to fail with: error: pathspec '21/merge' did not match any file(s) Use github.base_ref (the PR target branch) for pull_request events, falling back to github.ref_name for push events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
pull_request_targetwithpull_requestto prevent duplicate workflow runs when merging PRs to master.Previously, merging a PR fired both 'push' and 'pull_request_target' simultaneously, causing two runs to race for the
gh-pages force-push. The loser failed with a "cannot lock ref" error. Withpull_request, only the push event deploys on merge, while PRs still get build-tested.