Skip to content

[WIP] Deep copy annotations when using time_slice#538

Closed
JuliaSprenger wants to merge 1 commit intoNeuralEnsemble:masterfrom
INM-6:fix/annotations
Closed

[WIP] Deep copy annotations when using time_slice#538
JuliaSprenger wants to merge 1 commit intoNeuralEnsemble:masterfrom
INM-6:fix/annotations

Conversation

@JuliaSprenger
Copy link
Member

This aims at issue #536 by ensuring a deep copy of the annotation dictionary when using time_slice

@pep8speaks
Copy link

Hello @JuliaSprenger! Thanks for submitting the PR.

Line 35:1: E402 module level import not at top of file
Line 417:21: E127 continuation line over-indented for visual indent
Line 438:13: E122 continuation line missing indentation or outdented
Line 439:13: E122 continuation line missing indentation or outdented
Line 440:13: E122 continuation line missing indentation or outdented
Line 441:13: E122 continuation line missing indentation or outdented
Line 442:13: E122 continuation line missing indentation or outdented

Line 319:13: E122 continuation line missing indentation or outdented
Line 320:13: E122 continuation line missing indentation or outdented
Line 321:13: E122 continuation line missing indentation or outdented
Line 322:13: E122 continuation line missing indentation or outdented
Line 323:13: E122 continuation line missing indentation or outdented
Line 395:22: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 398:22: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Line 352:46: E231 missing whitespace after ','
Line 357:62: E231 missing whitespace after ','
Line 358:62: E231 missing whitespace after ','
Line 359:62: E231 missing whitespace after ','

Line 228:100: E501 line too long (166 > 99 characters)
Line 412:46: E231 missing whitespace after ','
Line 738:100: E501 line too long (102 > 99 characters)
Line 739:17: E122 continuation line missing indentation or outdented
Line 740:17: E122 continuation line missing indentation or outdented

Line 1038:5: E303 too many blank lines (2)

@samuelgarcia
Copy link
Contributor

@JuliaSprenger do you plan this for 0.7 ?

@JuliaSprenger
Copy link
Member Author

I won't have time to work on this in the coming days. If anybody feels bored you can take over. Otherwise we have to postpone this. Sorry :/

@muellerbjoern
Copy link
Contributor

@JuliaSprenger, @apdavison, Doesn't #668 implement all the intended changes?

@JuliaSprenger
Copy link
Member Author

I checked #668 and this covers all the cases I had in mind for this PR. So I will close this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants