Merged
Conversation
Contributor
Contributor
Author
|
Sounds good. Our release is due within the next two weeks to stay on schedule, so maybe we can ping Sam and see if he wants a hard review. In general I think I was okay with it as it is more a proof of principle for a future gap tolerance core PR. Also Happy New Year! |
Contributor
|
@zm711 @apdavison I modified the authors, release data, and codemeta.json. Are the changes ok? Since this has been hanging for a while (and it has some important fixes for reading IBL data!), I would suggest we proceed with it! |
alejoe91
approved these changes
Mar 11, 2026
apdavison
approved these changes
Mar 11, 2026
Contributor
|
Let's move forward, release more is better than release less. We should make those fixes available. |
Contributor
Author
|
Merged. I'll let you cut the release tomorrow while I'm at work! :) Otherwise I'll do it tomorrow evening :) |
Contributor
|
Tagged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo