[Showcase] Enchance headers with buffer id at BaseRawIO#1545
Closed
h-mayorquin wants to merge 1 commit intoNeuralEnsemble:masterfrom
Closed
[Showcase] Enchance headers with buffer id at BaseRawIO#1545h-mayorquin wants to merge 1 commit intoNeuralEnsemble:masterfrom
BaseRawIO#1545h-mayorquin wants to merge 1 commit intoNeuralEnsemble:masterfrom
Conversation
Contributor
Author
|
OK, so Sam decided to do this in one sweep. Let's close this once we are finished with #1544. |
Contributor
|
We said we would close with the merge of #1544. Reopen if needed Heberto. |
Contributor
Author
|
Thanks for closing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not mean to be merged but to add a concrete implementation to suggest in #1544. This PR probably is incomplete and it has errors.
The idea here is that the
BaseRawIOwill add post parsing logic to modify thesignal_streamsandsignal_channelsheaders by adding the buffer id if they are not in the new type yet. Same forsignal_channelswhere the buffer id will be added as an extra column. In all of those cases the buffer_id is just a carbon copy of the stream_id.This approach should enable the following workflow and progression plan: