Fix set_key_transform's set_type to give priority to pre-set value#313
Merged
shishirmk merged 3 commits intoNetflix:devfrom Sep 20, 2018
Merged
Fix set_key_transform's set_type to give priority to pre-set value#313shishirmk merged 3 commits intoNetflix:devfrom
shishirmk merged 3 commits intoNetflix:devfrom
Conversation
sakuraineed
force-pushed
the
fix_set_key_transform
branch
from
7db2b5c to
57f09c7
Compare
Collaborator
|
#310 is about singular and plural forms of the record_type. Could you add a spec for that too? |
Contributor
Author
|
@shishirmk Thanks for the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #310