Fixed broken path for output_log#50
Merged
ManlyMarco merged 1 commit intoNeighTools:masterfrom Apr 17, 2024
diehy:output_log_fix
Merged
Fixed broken path for output_log#50ManlyMarco merged 1 commit intoNeighTools:masterfrom diehy:output_log_fix
ManlyMarco merged 1 commit intoNeighTools:masterfrom
diehy:output_log_fix
Conversation
ManlyMarco
approved these changes
Feb 9, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being given the option for Doorstop to automatically redirect the output log is neat, and it saves me from running additional code to patch
mainDatafor the redirect.However, the path used for it is clearly incorrect, and I've noticed that it isn't just an issue for me: #39
After having a quick peek it appears that the wrong path variable is being used for the absolute directory path, resulting in it being trimmed early due to the filename length being short.
A quick change resolves this issue: