feat(preview): add public API for deviceFound and deviceLost for preview devices#4083
Merged
Fatme merged 4 commits intorelease-5.0.1from Nov 1, 2018
Merged
feat(preview): add public API for deviceFound and deviceLost for preview devices#4083Fatme merged 4 commits intorelease-5.0.1from
Fatme merged 4 commits intorelease-5.0.1from
Conversation
e9e2e50 to
957f0a4
Compare
957f0a4 to
569b498
Compare
75aeedd to
aeec0ac
Compare
KristianDD
approved these changes
Nov 1, 2018
| } | ||
|
|
||
| interface IPreviewDevicesService extends EventEmitter { | ||
| connectedDevices: Device[]; |
Contributor
There was a problem hiding this comment.
Do we need to expose a public setter? We could expose just a getConnectedDevices method.
|
|
||
| interface IPreviewDevicesService extends EventEmitter { | ||
| connectedDevices: Device[]; | ||
| onDevicesPresence(devices: Device[]): void; |
Contributor
There was a problem hiding this comment.
In the context of this service, this should be something like set/update ConnectedDevices.
DimitarTachev
approved these changes
Nov 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to expose
deviceFoundanddeviceLostfor preview devices as a public api so Sidekick can use them.PR Checklist