fix(preview): skip check if local plugin version is invalid #4044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(plugin.md) - Remove find and search commands from man pages
If the local version of the plugin cannot be parsed by `semver`, the check should be skipped and no warning shown. fixes #4043
Fatme
approved these changes
Oct 19, 2018
Contributor
Fatme
left a comment
Fatme
left a comment
There was a problem hiding this comment.
Great! Thanks for adding unit test!
Contributor
|
Can we still find a way to give the user a message that something is wrong with the plugin? |
Contributor
|
We decided to merge this PR with current fixes and to handle such plugins in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the local version of the plugin cannot be parsed by
semver, thecheck should be skipped and no warning shown.
fixes #4043