Skip to content

--noImplicitAny compiler flag #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fatme merged 1 commit into from
Aug 11, 2014
Merged

--noImplicitAny compiler flag #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ module.exports = function(grunt) {
module: 'commonjs',
sourceMap: true,
declaration: false,
removeComments: false
removeComments: false,
noImplicitAny: true
},

devlib: {
Expand Down
2 changes: 1 addition & 1 deletion lib/common
Open in desktop
Submodule common updated 19 files
+1 −1 commands/help.ts
+14 −1 declarations.d.ts
+8 −1 definitions/commands.d.ts
+16 −7 definitions/log4js.d.ts
+8 −8 definitions/logger.d.ts
+6 −6 definitions/node-fibers.d.ts
+22 −22 definitions/node.d.ts
+8 −1 definitions/properties-parser.d.ts
+2 −2 definitions/rimraf.d.ts
+6 −2 definitions/watchr.d.ts
+3 −3 errors.ts
+3 −3 extensions.ts
+5 −5 file-system.ts
+5 −6 helpers.ts
+7 −7 http-client.ts
+10 −10 logger.ts
+3 −3 services/cancellation.ts
+3 −3 services/commands-service.ts
+6 −7 yok.ts
4 changes: 2 additions & 2 deletions lib/definitions/npm.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
declare module "npm" {
var cache: string;
var commands: any[];
function load(config: Object, callback: (err: any, data: any) => void);
var commands: { [index: string]: any };
function load(config: Object, callback: (err: any, data: any) => void): void;
}
2 changes: 1 addition & 1 deletion lib/definitions/osenv.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
declare module "osenv" {
function home();
function home(): string;
}
2 changes: 1 addition & 1 deletion lib/definitions/shelljs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ declare module "shelljs" {
function cp(arg: string, sourcePath: string, destinationPath: string): void;
function cp(arg: string, sourcePath: string[], destinationPath: string): void;
function sed(arg: string, oldValue: any, newValue: string, filePath: string): void;
function mv(source: string[], destination: string);
function mv(source: string[], destination: string): void;
function grep(what: any, where: string): any;
}
2 changes: 1 addition & 1 deletion lib/node-package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class NodePackageManager implements INodePackageManager {
this.$logger.trace("Installing", packageName);

var future = new Future<void>();
npm.commands["install"](pathToSave, packageName, (err, data) => {
npm.commands["install"](pathToSave, packageName, (err: Error, data: any) => {
if(err) {
future.throw(err);
} else {
Expand Down
2 changes: 1 addition & 1 deletion lib/services/ios-project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class IOSProjectService implements IPlatformProjectService {
"-configuration", options.release,
"build"
];
var args = [];
var args: string[] = [];

if(options.device) {
args = basicArgs.concat([
Expand Down
4 changes: 2 additions & 2 deletions lib/services/platform-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import constants = require("./../constants");
import helpers = require("./../common/helpers");

class PlatformsData implements IPlatformsData {
private platformsData = {};
private platformsData : { [index: string]: any } = {};

constructor($androidProjectService: IPlatformProjectService,
$iOSProjectService: IPlatformProjectService) {
Expand All @@ -22,7 +22,7 @@ class PlatformsData implements IPlatformsData {
return Object.keys(this.platformsData);
}

public getPlatformData(platform): IPlatformData {
public getPlatformData(platform: string): IPlatformData {
return this.platformsData[platform];
}
}
Expand Down