Merged
Conversation
|
Test PASSed. |
Contributor
|
👍 |
1 similar comment
|
👍 |
When ANDROID_HOME environment variable is not set, we call childProcess exec and spawn with undefined command. This leads to "futures left behind" errors. Make sure the commands will be executed only in case they are not undefined. Also make sure that `tns prepare android` will fail immediately in case ANDROID_HOME is not set (currently it shows warning for ANDROID_HOME and shows error for compile SDK).
rosen-vladimirov
force-pushed
the
vladimirov/fix-android-home-log-trace
branch
from
10699a2 to
4834e80
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Dec 3, 2015
…e-log-trace Fix tns doctor command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ANDROID_HOME environment variable is not set, we call childProcess exec and spawn with undefined command.
This leads to "futures left behind" errors.
Make sure the commands will be executed only in case they are not undefined.
Also make sure that
tns prepare androidwill fail immediately in case ANDROID_HOME is not set (currently it shows warning for ANDROID_HOME and shows error for compile SDK).Related issue: #1242