Remove .ts from tns-core-modules package when moving it to platforms dir#1189
Merged
rosen-vladimirov merged 1 commit intoreleasefrom Nov 16, 2015
Merged
Conversation
The new tns-core-modules package has .d.ts files. We should skip them when moving tns-core-modules to platforms dir. The current logic is - copy everything from node_modules to tns_modules dir. After that move everything from tns_modules/tns-core-modules dir to tns_modules and delete tns-core-modules. Add logic to delete .ts file BEFORE moving the files from tns_modules/tns-core-modules dir to tns_modules.
|
Test PASSed. |
|
👍 |
1 similar comment
Contributor
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 16, 2015
…modules Remove .ts from tns-core-modules package when moving it to platforms dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new tns-core-modules package has .d.ts files. We should skip them when moving tns-core-modules to platforms dir.
The current logic is - copy everything from node_modules to tns_modules dir.
After that move everything from tns_modules/tns-core-modules dir to tns_modules and delete tns-core-modules.
Add logic to delete .ts files BEFORE moving the files from tns_modules/tns-core-modules dir to tns_modules.