Remove usage of non-public value field #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
test |
Contributor
Author
|
test --performance |
1 similar comment
Contributor
Author
|
test --performance |
vmutafov
force-pushed
the
vmutafov/remove-hidden-field-usage
branch
from
415f14a to
fa535f8
Compare
vtrifonov
approved these changes
Jul 29, 2019
vmutafov
added a commit
that referenced
this pull request
Aug 1, 2019
jamescodesthings
pushed a commit
to jamescodesthings/android-runtime
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1458
Currently, the runtime depends on accessing the hidden
valuefield of primitive boxing types to get their value. As of API 29 of android, this operation is not permitted. This PR fixes this behaviour by using the<type>Valuemethods for the different boxing types.