Skip to content

Backport binding refreshing #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdboom merged 2 commits into from
Jan 28, 2026
Merged

Backport binding refreshing #1529

mdboom merged 2 commits into from
Jan 28, 2026

Conversation

@leofang
Copy link
Member

@leofang leofang commented Jan 23, 2026

Description

Backport of #1468.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang added this to the cuda-python 13.1.2 & 12.9.6 milestone Jan 23, 2026
@leofang leofang self-assigned this Jan 23, 2026
@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jan 23, 2026
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 23, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Jan 23, 2026

/ok to test d310335

@leofang
Copy link
Member Author

leofang commented Jan 23, 2026

@mdboom would you mind taking a look at the NVML test failure? It seems we missed one or two backports.

@leofang leofang added P1 Medium priority - Should do and removed P0 High priority - Must do! labels Jan 23, 2026
@leofang
Copy link
Member Author

leofang commented Jan 23, 2026

(Lowering this to P1 because I don't see urgency in cutting a patch release 12.9.6. The cuFILE bug does not appear in this branch.)

@mdboom
Copy link
Contributor

mdboom commented Jan 28, 2026

/ok to test

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 28, 2026

/ok to test

@mdboom, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@mdboom
Copy link
Contributor

mdboom commented Jan 28, 2026

/ok to test

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 28, 2026

/ok to test

@mdboom, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@mdboom
Copy link
Contributor

mdboom commented Jan 28, 2026

/ok to test 8e92978

kkraus14
kkraus14 approved these changes Jan 28, 2026
View reviewed changes
cuda_bindings/cuda/bindings/_internal/nvfatbin.pxd
Comment on lines +25 to +30






Copy link
Collaborator

@kkraus14 kkraus14 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codegen issue?

@mdboom
Copy link
Contributor

mdboom commented Jan 28, 2026

@mdboom would you mind taking a look at the NVML test failure? It seems we missed one or two backports.

I added a commit here that backports the changes to the NVML tests. They seem to be passing now.

@mdboom mdboom merged commit a177798 into NVIDIA:12.9.x Jan 28, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@leofang leofang

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Milestone

cuda-python 13.1.2 & 12.9.6

Development

Successfully merging this pull request may close these issues.

3 participants

@leofang @mdboom @kkraus14