MNT: Consolidate BACKPORT_BRANCH into ci/versions.yml#1311
MNT: Consolidate BACKPORT_BRANCH into ci/versions.yml#1311leofang merged 14 commits intoNVIDIA:mainfrom
BACKPORT_BRANCH into ci/versions.yml#1311Conversation
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
|
/ok to test 351539f |
leofang
added
enhancement
The version check is no longer needed, see context: NVIDIA#1041 (comment).
This comment has been minimized.
This comment has been minimized.
|
/ok to test ca9a06f |
the Debian package is unfortunately discontinued, and it is simpler if we consolidate the yq calls in the same job where yq is available
|
/ok to test 9fdfa6c |
|
/ok to test f1af6cb |
|
/ok to test a26bfc5 |
|
/ok to test e5fac2b |
|
/ok to test 4011bb8 |
|
To avoid scope creep, the containerless exploration is now tracked in #1369. I'll revert and clean up the related changes to make this PR ready for review/merge. |
|
/ok to test 609f8a2 |
| ls -l $env:YQ_DIR | ||
| echo "$((Get-Location).Path)\\$env:YQ_DIR" >> $env:GITHUB_PATH | ||
| $env:Path += ";$((Get-Location).Path)\\$env:YQ_DIR" | ||
| yq --version |
There was a problem hiding this comment.
Non-blocking: can we use choco install yq to minimize the amount of powershell?
There was a problem hiding this comment.
It might be a good idea for this workflow since choco is provided in the GH-hosted VM. I can look into it later.
I avoided using it in most places because it did not work in one of the cases (can't recall which), and we had to cover workflows running on both self-hosted and GH-hosted runners, and the asymmetry is large enough that a custom script like the one I removed for ztsd makes the portability story much better.
|
Thanks, Phillip! |
|
Description
closes
Checklist