leading zero and formal/informal year fixes#378
Merged
mgrafu merged 3 commits intoNVIDIA:staging_hi_tnfrom Jan 20, 2026
Merged
Conversation
Signed-off-by: shreeshd-tn <shreeshd@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: shreeshd-tn <shreeshd@nvidia.com>
2b9ff41 to
2cc2b46
Compare
mgrafu
approved these changes
Jan 20, 2026
shreeshd-tn
added a commit
to shreeshd-tn/NeMo-text-processing
that referenced
this pull request
Jan 20, 2026
Resolved trivial conflicts - content is identical, just different commit history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Added fix for cardinal class - Previously inputs like 073 would go unprocessed.
Added feature in measure class - Added support for formal vs informal year based on digit length or decimal.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.