adding icons in contact page #96
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/s-ayush2903/nwoc-website-alpha-version/j4n9ftxta |
|
@Vishal-raj-1 This is not how it works, in order to open a PR you have to make sure that no one else is working on it and seek approval by maintainer to work on the issue, you never commented on the issue that you want to work on it and it was not good to assign you as neither had commented or mentioned anywhere in the issue about your interest in it moreover, one more participant was involved in the corresponding issue which displayed their interest/willingness to work on it. This isn't for this repo only, this is a rule of thumb in open source projects |
|
I have open this issue for myself 🙃. Sorry I have forget to mentioned that
I am working on that !!
|
s-ayush2903
left a comment
There was a problem hiding this comment.
- You can definitely use better(and visible) icon for gitter, use gmail icon for gmail address and the normal mail icon for the webmail(the one with domain name
@iitp.ac.in)
Also the current UX doesn't look pleasant to me, any thoughts do you have and I'm pinging here @Ankit7Das as well for input on the same, because those icons below pictures of organizers look a bit weird(because of their noticably large size)
|
Also @Vishal-raj-1 you needn't mark the work as done unless you've done it in any commit, you should uncheck the appropriate checkboxes(in the PR description) : ) |
ok sure !!
So I can do one thing, will do text align left(like before) and decrease the font-size of facebook and github icons. |
updated !! |
|
@s-ayush2903 @Ankit7Das I have resolved the issues !! Please review it 🔥 |
|
The UI looks fine, good work 👍 |
|
@s-ayush2903 @Ankit7Das I have restore the previous indentation. Please review it !! 🔥 |
|
#102 will solve this issue as well !! I am closing this PR. |
|
@Vishal-raj-1 You were not supposed to close it, this is fine, we can merge it. I'm reopening it 👍 |
Sir I have closing this PR !! Because what I have done is solving one issue and make one PR and solving another issue on another branch. But I am opening new branch after opening the PR !! from the next time I will open the branch first then do changes and make a PR from that branch and start working on another issue on another branch. Let me clarify you what happen here !! This PR solve the issues of adding icons in contact page, #101 will solve this issue as well drop down list issues and #102 will solve this two issues and search bar. sorry for the inconvenience. I was stuck in branching. I can do rebasing as well(fixup and squashing commits) but I feel there is no need to do that because it will deploy with the last commit that we have done on PR !! |
Thank you for merging !! Feeling relaxed I was totally stuck because of that indentation. |
Issue Fix
Fixes #92
Description of changes made
I have adding the icons which look nice both in desktop and mobile view. I have adding some hover effect as well. I have centralize the images. (check video for more info)
Submissions guide:
Video
Contact._.NJACK.Winter.of.Code.-.Google.Chrome.2021-01-04.19-55-18.mp4
@s-ayush2903 @Ankit7Das Sir Please Review my PR !!