feat: Fixed mypy issues, updated test vicinity hub repo#61
Merged
Conversation
Codecov ReportAttention: Patch coverage is
|
stephantul
suggested changes
Feb 28, 2025
Contributor
stephantul
left a comment
stephantul
left a comment
There was a problem hiding this comment.
The mixin doesn't need an init, that's what makes it a mixin. It's a bit difficult to type, but adding an init is probably not the best way to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the hub functionality a bit. It didn't pass mypy (I forgot that it didn't run in CI), and while fixing mypy issues I made some changes to make it more aligned with how we handle optional dependencies in Model2Vec. Biggest change is that it's no longer a mixin, since the typing became really nasty when I tried to keep it a mixin, and I think it can just be functions like this.