Skip to content

Comments

3.0.0#20

Merged
MajorLift merged 3 commits intomainfrom
release/3.0.0
Jun 3, 2024
Merged

3.0.0#20
MajorLift merged 3 commits intomainfrom
release/3.0.0

Conversation

@MajorLift
Copy link

@MajorLift MajorLift commented May 29, 2024 •
edited
Loading

@MajorLift MajorLift self-assigned this May 29, 2024
@MajorLift MajorLift requested a review from a team May 29, 2024 22:46
This was referenced May 29, 2024
Merged
Closed
@MajorLift MajorLift linked an issue May 30, 2024 that may be closed by this pull request
Use ts-bridge as build tool, set moduleResolution to NodeNext #21
Closed
cryptodev-2s
cryptodev-2s previously approved these changes Jun 3, 2024
View reviewed changes
Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mcmire
mcmire previously approved these changes Jun 3, 2024
View reviewed changes
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

MajorLift
MajorLift commented Jun 3, 2024
View reviewed changes
@MajorLift MajorLift dismissed stale reviews from mcmire and cryptodev-2s via b0a7d5d June 3, 2024 15:58
cryptodev-2s
cryptodev-2s approved these changes Jun 3, 2024
View reviewed changes
Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift merged commit 545c215 into main Jun 3, 2024
@MajorLift MajorLift deleted the release/3.0.0 branch June 3, 2024 16:02
MajorLift added a commit that referenced this pull request Jun 3, 2024
@MajorLift
Revert "3.0.0 (#20)"
ddd2006 
This reverts commit 545c215.
MajorLift added a commit that referenced this pull request Jun 3, 2024
@MajorLift
Revert "3.0.0 (#20)" (#23)
3eb8b63 
This reverts commit 545c215.

The previous release PR for 3.0.0 wasn't generated by manually
triggering the `create-release-pr` workflow, resulting in a failure to
publish.
@MajorLift MajorLift mentioned this pull request Jun 3, 2024
Merged
MajorLift added a commit that referenced this pull request Jun 3, 2024
@github-actions @MajorLift
3.0.0 (#24)
4a2a7b0 
This is the release candidate for version 3.0.0 (previously submitted as
#20).

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
MajorLift added a commit to MetaMask/utils that referenced this pull request Jun 4, 2024
@MajorLift @mcmire
Use @metamask/superstruct, set moduleResolution to NodeNext (#185)
631d1eb 
## Explanation

As part of our OKR for upgrading TypeScript to v5.0+ (Q2 2024 O3KR4), we
are updating our core dependencies to generate builds and type
declarations for both CJS and ESM.

- Replaces all references to `superstruct` with ESM-compatible
`@metamask/superstruct` fork.
- Set TypeScript `module`, `moduleResolution` options to `NodeNext`.

## References

- Closes: #186
- Blocks: MetaMask/core#3651
- Blocked by: MetaMask/superstruct#20

## Changelog

```md
### Changed

- **BREAKING:** Replace dependency `superstruct` `^1.0.3` with ESM-compatible `@metamask/superstruct` `^3.0.0` ([#185](#185)).
- Bump devDependency `typescript` from `~4.8.4` to `~5.0.4` ([#185](#185)).
```

---------

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mcmire mcmire mcmire left review comments

Assignees

@MajorLift MajorLift

Labels

team-wallet-framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ts-bridge as build tool, set moduleResolution to NodeNext

3 participants

@MajorLift @mcmire @cryptodev-2s