feat: Shield: log transaction and signature#6633
Conversation
matthiasgeihs
force-pushed
the
mg/shield/log-confirmation
branch
from
b0573d4 to
62a74ae
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matthiasgeihs
force-pushed
the
mg/shield/log-confirmation
branch
from
62a74ae to
71e30cd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| // Log signature once the signature request has been fulfilled. | ||
| if ( | ||
| signatureRequest.status === SignatureRequestStatus.Signed && | ||
| signatureRequest.status !== previousSignatureRequest?.status |
There was a problem hiding this comment.
Just wanna verify, this might change when we wanna do log on the confirmation reject, right?
| signatureRequest.status === SignatureRequestStatus.Signed && | ||
| signatureRequest.status !== previousSignatureRequest?.status | ||
| ) { | ||
| this.#logSignature(signatureRequest).catch( |
There was a problem hiding this comment.
I understand the log logic will probably change after the discussion today.
But as of now, logging should be done only when the coverage result is available?
| await this.#backend.logSignature({ | ||
| coverageId, | ||
| signature: sig, | ||
| // Status is 'shown' because the coverageId can only be retrieved after |
There was a problem hiding this comment.
I understand the log logic will probably change after the discussion today.
But as of now, logging should be done only when the coverage result is available?
| await this.#backend.logTransaction({ | ||
| coverageId, | ||
| transactionHash: txHash, | ||
| // Status is 'shown' because the coverageId can only be retrieved after |
There was a problem hiding this comment.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2 participants
Explanation
Context: ShieldController
Once a transaction is submitted or a signature request is fulfilled, the transaction hash or signature, respectively, are logged on the backend.
References
Checklist