Release 180.0.0 by MajorLift · Pull Request #4548 · MetaMask/core

MajorLift · 2024-07-23T18:00:56Z

Explanation

This is the release candidate for v180.0.0:

@metamask/accounts-controller@18.0.0 (major)
@metamask/assets-controllers@37.0.0 (major)
@metamask/chain-controllers@0.1.1 (patch)
@metamask/ens-controller@13.0.1 (patch)
@metamask/eth-json-rpc-provider@4.1.2 (patch)
@metamask/gas-fee-controller@19.0.1 (patch)
@metamask/keyring-controller@17.1.2 (patch)
@metamask/message-manager@10.0.2 (patch)
@metamask/network-controller@20.1.0 (minor)
@metamask/notification-services-controller@0.2.0 (minor)
@metamask/polling-controller@9.0.1 (patch)
@metamask/preferences-controller@13.0.1 (patch)
@metamask/polling-controller@9.0.1 (patch)
@metamask/profile-sync-controller@0.2.0 (minor)
@metamask/queued-request-controller@4.0.0 (major)
@metamask/selected-network-controller@17.0.0 (major)
@metamask/signature-controller@18.0.1 (patch)
@metamask/transaction-controller@35.0.1 (patch)
@metamask/user-operation-controller@14.0.1 (patch)

References

Closes Upgrade to TypeScript v5.0 #3651
Unblocks new releases in core.

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

socket-security · 2024-07-23T18:01:34Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/profile-sync-controller@0.1.4, npm/@metamask/selected-network-controller@16.0.0

View full report↗︎

…se candidate

Prithpal-Sooriya

Satisfied with the notifications side (@metamask/notification-services-controller, @metamask/profile-sync-controller)

mcmire

Had some suggestions!

packages/assets-controllers/CHANGELOG.md

packages/polling-controller/CHANGELOG.md

packages/queued-request-controller/CHANGELOG.md

packages/transaction-controller/CHANGELOG.md

mcmire · 2024-07-24T21:16:52Z

packages/ens-controller/CHANGELOG.md


 ## [Unreleased]

+### Changed


Are we releasing this package? If not, should we add these changelog entries in another PR?

To include the changes in #4556, I added releases for:

ens-controller (a3308b8)

gas-fee-controller (ac917f0)

selected-network-controller, queued-request-controller 61670f3

transaction-controller, user-operation-controller 773baa3

Every package with a diff in this PR is now being released (excluding json-rpc-engine).

mcmire · 2024-07-24T21:19:58Z

packages/profile-sync-controller/CHANGELOG.md

+- Upgrade TypeScript to v5.0 and set `moduleResolution` option to `Node16` ([#3645](https://github.com/MetaMask/core/pull/3645))
+- Bump `@metamask/base-controller` from `^6.0.0` to `^6.0.2` ([#4517](https://github.com/MetaMask/core/pull/4517), [#4544](https://github.com/MetaMask/core/pull/4544))
+- Bump `@metamask/snaps-controllers` from `^8.1.1` to `^9.3.1` ([#3645](https://github.com/MetaMask/core/pull/3645))
+  - Bump peerDependency `@metamask/snaps-controllers` from `^8.1.1` to `^9.3.0`


If we are bumping a peer dependency then this is a breaking change as the client will also need to upgrade this dependency. Should we bump this package to 0.2.0?

@Prithpal-Sooriya How would you feel about using a minor version bump to indicate that there are breaking changes in the release?

Upgraded both {notifications-services,profile-sync}-controller to 0.2.0: f842953

@Prithpal-Sooriya Let me know if this goes against the team's intentions. I can simply revert that commit.

mcmire · 2024-07-24T21:21:33Z

packages/accounts-controller/CHANGELOG.md

+- Bump `@metamask/snaps-sdk` from `^4.2.0` to `^6.1.1` ([#3645](https://github.com/MetaMask/core/pull/3645), [#4547](https://github.com/MetaMask/core/pull/4547))
+- Bump `@metamask/snaps-utils` from `^7.4.0` to `^7.8.1` ([#3645](https://github.com/MetaMask/core/pull/3645), [#4547](https://github.com/MetaMask/core/pull/4547))
+- Bump `@metamask/utils` from `^8.3.0` to `^9.1.0` ([#4516](https://github.com/MetaMask/core/pull/4516), [#4529](https://github.com/MetaMask/core/pull/4529))
+- Bump peerDependency `@metamask/snaps-controllers` from `^8.1.1` to `^9.3.0` ([#3645](https://github.com/MetaMask/core/pull/3645))


If we're bumping a peer dependency by a major then this would be a breaking change as it forces the client to also upgrade this package. Should we bump the version to 18.0.0?

Good point. Fixed here! 2e13b78

OGPoyraz · 2024-07-25T09:47:24Z

Hi there! @MajorLift
May I ask if we can include a3bfbce into this release?
This is fairly simple one adds a public method to NFTController.

MajorLift · 2024-07-25T14:06:27Z

@OGPoyraz Of course! Any commits merged into main while this PR is open will need to be added to this release in any case. Thanks for bringing this one to my attention.

Changelog updated here: 83060c1

MajorLift · 2024-07-25T18:35:48Z

packages/chain-controller/CHANGELOG.md

+- Bump `@metamask/snaps-controllers` from `^8.1.1` to `^9.3.1` ([#3645](https://github.com/MetaMask/core/pull/3645), [#4547](https://github.com/MetaMask/core/pull/4547))
+- Bump `@metamask/snaps-sdk` from `^4.2.0` to `^6.1.1` ([#3645](https://github.com/MetaMask/core/pull/3645), [#4547](https://github.com/MetaMask/core/pull/4547))
+- Bump `@metamask/snaps-utils` from `^7.4.0` to `^7.8.1` ([#3645](https://github.com/MetaMask/core/pull/3645), [#4547](https://github.com/MetaMask/core/pull/4547))


@MetaMask/accounts-engineers Should any of these be peer dependencies (esp. snaps-controllers)?

See chore: Remove redundant dependencies #4556

Typically the snaps controller is added as a peer dependency, for the same reason as the other controllers. I don't see the others as being used as peer deps though.

Perhaps we can move the controller to be a peer dependency later, since it's a pre-existing issue.

packages/assets-controllers/CHANGELOG.md

MajorLift · 2024-07-25T20:27:37Z

It's worth noting that once we have our codeowners file updated, a PR covering the same packages as this one will require 6 approvals (accounts, assets, confirmations, notifications, wallet-api-platform, wallet-framework) possibly multiple times throughout the review process.

One way to make this a little less painful might be to first ask for approval from codeowners who own more packages in the PR (wallet-framework, confirmations), before pinging codeowners who own less packages.

packages/assets-controllers/CHANGELOG.md

Gudahtt

Left a few corrections mostly minor

packages/assets-controllers/CHANGELOG.md

packages/message-manager/CHANGELOG.md

packages/network-controller/CHANGELOG.md

packages/profile-sync-controller/CHANGELOG.md

packages/selected-network-controller/CHANGELOG.md

packages/signature-controller/CHANGELOG.md

packages/transaction-controller/CHANGELOG.md

packages/user-operation-controller/package.json

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

…" heading

Gudahtt

LGTM!

MajorLift · 2024-07-26T14:40:24Z

packages/profile-sync-controller/CHANGELOG.md

+### Added
+
+- Add and export object `USER_STORAGE_SCHEMA`, function `getFeatureAndKeyFromPath`, and type `UserStoragePath` ([#4543](https://github.com/MetaMask/core/pull/4543))
+- Add `connectSnap` method to the `JwtBearerAuth` class for connecting to snap after initializing the Profile Sync SDK ([#4560](https://github.com/MetaMask/core/pull/4560))


@Prithpal-Sooriya I added an entry for the new commit adding connectSnap.

This is the release candidate for `v180.0.0`: - `@metamask/accounts-controller@18.0.0` (major) - `@metamask/assets-controllers@37.0.0` (major) - `@metamask/chain-controllers@0.1.1` (patch) - `@metamask/ens-controller@13.0.1` (patch) - `@metamask/eth-json-rpc-provider@4.1.2` (patch) - `@metamask/gas-fee-controller@19.0.1` (patch) - `@metamask/keyring-controller@17.1.2` (patch) - `@metamask/message-manager@10.0.2` (patch) - `@metamask/network-controller@20.1.0` (minor) - `@metamask/notification-services-controller@0.2.0` (minor) - `@metamask/polling-controller@9.0.1` (patch) - `@metamask/preferences-controller@13.0.1` (patch) - `@metamask/polling-controller@9.0.1` (patch) - `@metamask/profile-sync-controller@0.2.0` (minor) - `@metamask/queued-request-controller@4.0.0` (major) - `@metamask/selected-network-controller@17.0.0` (major) - `@metamask/signature-controller@18.0.1` (patch) - `@metamask/transaction-controller@35.0.1` (patch) - `@metamask/user-operation-controller@14.0.1` (patch) - Closes #3651 - Unblocks new releases in core. - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>

MajorLift added 2 commits July 23, 2024 13:52

Initialize Release 180.0.0

e7ede77

Update Release 180.0.0

5359a60

MajorLift added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Jul 23, 2024

MajorLift requested a review from a team July 23, 2024 18:00

MajorLift self-assigned this Jul 23, 2024

MajorLift added the DO-NOT-MERGE label Jul 23, 2024

MajorLift added 2 commits July 23, 2024 14:53

Update changelogs for release packages

a8c25d2

Leave unreleased changelog entries for future release

c35839c

MajorLift requested a review from Prithpal-Sooriya July 23, 2024 18:55

MajorLift removed the DO-NOT-MERGE label Jul 23, 2024

MajorLift added 3 commits July 23, 2024 15:03

Add @metamask/signature-controller@18.0.1 to release

7325e9a

Add unreleased changelog entries for version bumps performed in relea…

a28f7ea

…se candidate

Add unreleased changelog entries for future releases

9b88eec

MajorLift linked an issue Jul 23, 2024 that may be closed by this pull request

Upgrade to TypeScript v5.0 #3651

Closed

1 task

Linter fixes

647fa4d

MajorLift marked this pull request as ready for review July 23, 2024 19:31

MajorLift requested a review from a team as a code owner July 23, 2024 19:31

MajorLift requested a review from a team July 23, 2024 19:31

Prithpal-Sooriya previously approved these changes Jul 23, 2024

View reviewed changes

matthewwalsh0 previously approved these changes Jul 24, 2024

View reviewed changes

MajorLift requested a review from mcmire July 24, 2024 13:59

MajorLift mentioned this pull request Jul 24, 2024

Upgrade to TypeScript v5.0 and set module{,Resolution} option to Node16 #3645

Merged

57 tasks

mcmire reviewed Jul 24, 2024

View reviewed changes

MajorLift added 2 commits July 25, 2024 09:36

Merge branch 'main' into release/180.0.0

6c936cf

Add changelogs for commits merged from main

83060c1

MajorLift dismissed stale reviews from matthewwalsh0 and Prithpal-Sooriya via 83060c1 July 25, 2024 13:52

MajorLift requested review from a team, Prithpal-Sooriya and matthewwalsh0 July 25, 2024 18:30

MajorLift commented Jul 25, 2024

View reviewed changes

MajorLift requested review from a team July 25, 2024 19:24

Gudahtt reviewed Jul 25, 2024

View reviewed changes

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved

Prithpal-Sooriya previously approved these changes Jul 25, 2024

View reviewed changes

MajorLift commented Jul 25, 2024

View reviewed changes

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved

MajorLift commented Jul 25, 2024

View reviewed changes

packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved

Move messenger allowlist addition changelog entries to "Changed" heading

225ed0f

MajorLift dismissed Prithpal-Sooriya’s stale review via 225ed0f July 25, 2024 20:19

mcmire previously approved these changes Jul 25, 2024

View reviewed changes

Gudahtt reviewed Jul 26, 2024

View reviewed changes

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved

Gudahtt requested changes Jul 26, 2024

View reviewed changes

Apply suggestions from code review

d19d49b

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

MajorLift dismissed mcmire’s stale review via d19d49b July 26, 2024 14:26

MajorLift added 4 commits July 26, 2024 10:29

Fix lockfile

dd39bee

Move required function parameter addition breaking chnage to "Changed…

d7d7985

…" heading

Merge branch 'main' into release/180.0.0

96f428e

Add changelog entry for new main commit

4f6c79d

Gudahtt approved these changes Jul 26, 2024

View reviewed changes

MajorLift commented Jul 26, 2024

View reviewed changes

matthewwalsh0 approved these changes Jul 26, 2024

View reviewed changes

MajorLift merged commit a429a95 into main Jul 26, 2024

MajorLift deleted the release/180.0.0 branch July 26, 2024 15:23

Uh oh!

Conversation

MajorLift commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

socket-security bot commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcmire Jul 24, 2024

Choose a reason for hiding this comment

Uh oh!

MajorLift Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

mcmire Jul 24, 2024

Choose a reason for hiding this comment

Uh oh!

MajorLift Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

MajorLift Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcmire Jul 24, 2024

Choose a reason for hiding this comment

Uh oh!

MajorLift Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OGPoyraz commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MajorLift commented Jul 25, 2024

Uh oh!

MajorLift Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gudahtt Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MajorLift commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gudahtt left a comment

MajorLift commented Jul 23, 2024 •

edited

Loading

socket-security bot commented Jul 23, 2024 •

edited

Loading

MajorLift Jul 25, 2024 •

edited

Loading

MajorLift Jul 25, 2024 •

edited

Loading

OGPoyraz commented Jul 25, 2024 •

edited

Loading

MajorLift Jul 25, 2024 •

edited

Loading

MajorLift commented Jul 25, 2024 •

edited

Loading