Merged
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
d19b2a3 to
c426abe
Compare
cf1da22 to
4eb212c
Compare
4eb212c to
2b79296
Compare
mikesposito
approved these changes
Jul 9, 2024
Member
mikesposito
left a comment
There was a problem hiding this comment.
These changes look good!
I noticed we left unchanged FakeProvider: are we supposed to remove sendAsync from the class or any other changes related to this work?
Contributor
Author
Hi Michele, FakeProvider has already been updated in a previous PR to include the request method. I had to make this change along with the SafeEventEmitterProvider updates; otherwise, the tests would not pass. You can see the updated FakeProvider here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
After updating the
SafeEventEmitterProviderto support EIP-1193, I have made the following changes:sendAsyncand replaced it with therequestmethod.corerepository:NetworkControllertestssendAsyncmethod. These now use therequestmethod with the correct method signature:SelectedNetworkControllertestscreateAutoManagedNetworkClienttestsReferences
Changelog
Checklist