Skip to content

Delete network status controller#298

Merged
rekmarks merged 1 commit intodevelopfrom
delete-network-status-controller
Nov 9, 2020
Merged

Delete network status controller#298
rekmarks merged 1 commit intodevelopfrom
delete-network-status-controller

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Nov 9, 2020

Deletes the network status controller and removes all references thereto.

@rekmarks rekmarks requested a review from a team as a code owner November 9, 2020 16:23
@estebanmino estebanmino mentioned this pull request Nov 9, 2020
Merged
3 tasks
danjm
danjm approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gudahtt
Gudahtt approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks
Copy link
Member Author

rekmarks commented Nov 9, 2020

I don't know why it keeps doing this, but the status checks aren't happening even though the pipeline is passing: https://app.circleci.com/pipelines/github/MetaMask/controllers?branch=delete-network-status-controller

@rekmarks rekmarks merged commit cba7aa1 into develop Nov 9, 2020
@rekmarks rekmarks deleted the delete-network-status-controller branch November 9, 2020 17:01
@rekmarks rekmarks mentioned this pull request Nov 9, 2020
Merged
@Gudahtt Gudahtt mentioned this pull request Nov 4, 2021
Closed
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@rekmarks @MajorLift
Delete network status controller (#298)
5fd9171
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@rekmarks @MajorLift
Delete network status controller (#298)
cb15f35
Mrtenz added a commit that referenced this pull request Oct 16, 2025
@github-actions @Mrtenz
11.0.4 (#298)
e62ae68 
This is the release candidate for version 11.0.4.

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekmarks @Gudahtt @danjm