Closed
Conversation
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Refactor function to get cache identifier The function `cacheIdentifierForPayload` has been renamed to `cacheIdentifierForRequest`, and refactored to accept a JSON-RPC request rather than the `Payload` type. The function `paramsWithoutBlockTag` has been updated to accept a JSON- RPC request rather than a `Payload` as well. I noticed that this function wasn't being used anywhere, so the `export` was removed as well. The `block-cache` and `inflight-cache` middleware required some internal updates to accomodate these type changes. No functional changes or external-facing type changes have been made. Documentation and tests have been added. This brings test coverage for `cache.ts` up to 100%. Relates to #176 in that it helps unblock the necessary changes. * Make `method` parameter mandatory for cache utility functions The `method` parameter is now mandatory for the cache utility functions. It was only made optional in the first place as a side- effect of an erroneous type that was being used (`Payload`), which has now been replaced. * Remove leftover merge marger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.