Skip to content

feature: preferences set selected address#178

Merged
estebanmino merged 2 commits intodevelopfrom
feature/preferences-set-selected-address
Nov 11, 2019
Merged

feature: preferences set selected address#178
estebanmino merged 2 commits intodevelopfrom
feature/preferences-set-selected-address

Conversation

@estebanmino
Copy link
Contributor

This PR adds a new setSelectedAddress method to PreferencesController to update selected address.

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #178 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #178   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           23     23           
  Lines         1514   1515    +1     
  Branches       210    210           
======================================
+ Hits          1514   1515    +1
Impacted Files Coverage Δ
src/user/PreferencesController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8677333...5151089. Read the comment docs.

@estebanmino estebanmino merged commit 0ac4029 into develop Nov 11, 2019
@estebanmino estebanmino deleted the feature/preferences-set-selected-address branch November 11, 2019 16:15
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 5.0.2 to 8.1.0.
- [Release notes](https://github.com/MetaMask/utils/releases)
- [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md)
- [Commits](MetaMask/utils@v5.0.2...v8.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/utils"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Two middleware functions accept an additional request property called
`skipCache`. Previously the return types for these middleware did not
include this property. It was supported internally only by casting.

The return type of this middleware has been updated to reflect that
this property is accepted. It has also been made optional. It was
optional in practice already, this just wasn't reflected in the
internal type used.

This changes the return type of the `block-cache` and `inflight-cache`
middleware, but the new types should be fully compatible with the old
types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants