Merged
Conversation
Contributor
Author
|
it will fix MetaMask/metamask-mobile#1171 |
Codecov Report
@@ Coverage Diff @@
## develop #177 +/- ##
======================================
Coverage 100% 100%
======================================
Files 23 23
Lines 1512 1514 +2
Branches 210 210
======================================
+ Hits 1512 1514 +2
Continue to review full report at Codecov.
|
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* late provider stop * fix * rename to safelyStopProvider
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* late provider stop * fix * rename to safelyStopProvider
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Refactor cache helper methods Refactor cache helper methods to no longer use the `Payload` type to access the request method. Instead they now take the method directly. This relates to #176, in that it reduces the number of places where we are using this `Payload` type that we need to eliminate for #176. * Add docs and tests * Add canCache refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug happening between stopping the provider listener and setting a new provider.
By doing
https://github.com/MetaMask/gaba/compare/bugfix/provider-stop?expand=1#diff-e6a23ff500e4183b5eba5bca9a0df0bdL136
we're unsubscribing the provider to handle errors from
https://github.com/MetaMask/gaba/compare/bugfix/provider-stop?expand=1#diff-e6a23ff500e4183b5eba5bca9a0df0bdL101
causing that we have an active provider exposed to throwable errors without handling it properly.
This PR sets a threshold to stop it after a new provider is set, to make sure that we're not exposed to errors coming from the provider.