Persist currentCurrency from state when re-initialising controller#173
Merged
whymarrh merged 4 commits intoMetaMask:developfrom Nov 3, 2019
rickycodes:develop
Merged
Persist currentCurrency from state when re-initialising controller#173whymarrh merged 4 commits intoMetaMask:developfrom rickycodes:develop
whymarrh merged 4 commits intoMetaMask:developfrom
rickycodes:develop
Conversation
Contributor
Author
|
I'm going to add a test case for this in a moment :) |
rickycodes
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #173 +/- ##
======================================
Coverage 100% 100%
======================================
Files 23 23
Lines 1498 1499 +1
Branches 209 210 +1
======================================
+ Hits 1498 1499 +1
Continue to review full report at Codecov.
|
danjm
reviewed
Nov 1, 2019
danjm
reviewed
Nov 1, 2019
brunobar79
reviewed
Nov 1, 2019
Contributor
|
@estebanmino didn’t we fix this on the app side while passing the initial state to the engine? |
Contributor
|
Looks good to me but I'll wait for Bruno's comments to be addressed before approving. |
Contributor
Author
|
@brunobar79 I removed the version pinning, which should negate the need to update the yarn.lock and npm-shrinkwrap.json (but the next person coming into this might experience the same build issues?) |
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
kanthesha
pushed a commit
that referenced
this pull request
Oct 19, 2023
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
* BREAKING: Remove support for Node.js 14,15,17,19 * Drop Node.js 20 support due todevDependency eslint-plugin-jest conflicting version range
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 3.0.3 to 3.4.0. - [Release notes](https://github.com/MetaMask/utils/releases) - [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md) - [Commits](MetaMask/utils@v3.0.3...v3.4.0) --- updated-dependencies: - dependency-name: "@metamask/utils" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: MetaMask/metamask-extension#6710
re: the pinning, when I installed this I got tsc
Version 3.6.4which resulted in the following:
builds fine with
3.5.3