Skip to content

Feature: speed up transaction#172

Merged
estebanmino merged 8 commits intodevelopfrom
feature/speed-up-transaction
Nov 11, 2019
Merged

Feature: speed up transaction#172
estebanmino merged 8 commits intodevelopfrom
feature/speed-up-transaction

Conversation

@estebanmino
Copy link
Contributor

This PR

  • Adds a speedUpTransaction method to be able to speed up transactions
  • Fixes cancelTransaction update since it wasn't working correctly

Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #172 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #172   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           23     23           
  Lines         1499   1512   +13     
  Branches       210    210           
======================================
+ Hits          1499   1512   +13
Impacted Files Coverage Δ
src/transaction/TransactionController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2771853...6c5d573. Read the comment docs.

@estebanmino estebanmino merged commit 927181e into develop Nov 11, 2019
@estebanmino estebanmino deleted the feature/speed-up-transaction branch November 11, 2019 15:55
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* speed upo method

* correctly update tx and test

* handle fail

* fix cancel transaction update

* rm safely execute

* fix tests
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* speed upo method

* correctly update tx and test

* handle fail

* fix cancel transaction update

* rm safely execute

* fix tests
kanthesha added a commit that referenced this pull request Oct 19, 2023
* applied eslint rules from core monorepo and fixed the errors

* added eslint-import-resolver-typescript devDependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants