Skip to content

Comments

SSO integration for EE. Initial implementation and some refactoring#458

Merged
varmar05 merged 16 commits intomasterfrom
457-sso-deployment-workflow-for-ee
Jun 19, 2025
Merged

SSO integration for EE. Initial implementation and some refactoring#458
varmar05 merged 16 commits intomasterfrom
457-sso-deployment-workflow-for-ee

Conversation

@fernandinand
Copy link
Contributor

No description provided.

@fernandinand fernandinand linked an issue May 23, 2025 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 23, 2025

Pull Request Test Coverage Report for Build 15391145754

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.647%

Totals Coverage Status
Change from base Build 14989844321: 0.0%
Covered Lines: 6956
Relevant Lines: 7590

💛 - Coveralls

Copy link
Collaborator

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice ... some minor enhancements and test if everything goes right.

@MarcelGeo MarcelGeo marked this pull request as ready for review June 6, 2025 09:01
- do not expose port for polis
- readme formating and AI text updates
- add sso api key to sso-init.sh
- get rid of boxy_host
@MarcelGeo MarcelGeo force-pushed the 457-sso-deployment-workflow-for-ee branch from 219fbdf to 1e96300 Compare June 9, 2025 16:10
@MarcelGeo
Copy link
Collaborator

MarcelGeo commented Jun 9, 2025

Hey guys @fernandinand , @varmar05 It worked to me on my local machine. I made some changes, but it works.

We have deal with @tomasMizera , that we do not need to pass service id to SSO_SERVER_PRODUCT_ID - just dummy string will be used.

After real images will be ready in registry, we can merge this and update image tags.

@MarcelGeo MarcelGeo requested a review from varmar05 June 9, 2025 16:23
@MarcelGeo MarcelGeo marked this pull request as draft June 9, 2025 16:23
@tomasMizera
Copy link
Collaborator

Hi guys, we should also be able to set some default redirect URLs (for mobile and plugin) and some more customization, see https://lutraconsulting.slack.com/archives/C08BN2CL0V9/p1747126180470749

@MarcelGeo
Copy link
Collaborator

Hi guys, we should also be able to set some default redirect URLs (for mobile and plugin) and some more customization, see https://lutraconsulting.slack.com/archives/C08BN2CL0V9/p1747126180470749

Ok. Let me know image version. 🥳

@varmar05
Copy link
Collaborator

Hey guys @fernandinand , @varmar05 It worked to me on my local machine. I made some changes, but it works.

We have deal with @tomasMizera , that we do not need to pass service id to SSO_SERVER_PRODUCT_ID - just dummy string will be used.

After real images will be ready in registry, we can merge this and update image tags.

Once we have final docker images I would pass it to @RastoHu for final test (in fresh environment).

- disable INTERNAL_URL in templates
- move internal_url to init script
- removed some readme parts as it will be in docs
@MarcelGeo MarcelGeo marked this pull request as ready for review June 19, 2025 10:12
@varmar05 varmar05 merged commit 801a7a8 into master Jun 19, 2025
3 of 4 checks passed
@MarcelGeo MarcelGeo deleted the 457-sso-deployment-workflow-for-ee branch September 24, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSO deployment workflow for EE

5 participants