Skip to content

add conformance tests into client unit tests#9

Merged
IlyaFaer merged 12 commits intov4_post_policiesfrom
post_policy_conformance_tests
Mar 31, 2020
Merged

add conformance tests into client unit tests#9
IlyaFaer merged 12 commits intov4_post_policiesfrom
post_policy_conformance_tests

Conversation

@IlyaFaer
Copy link
Collaborator

Add conformance tests for POST policy V4 generation method

@IlyaFaer IlyaFaer marked this pull request as ready for review March 25, 2020 11:01
Copy link

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IlyaFaer have one question.

Copy link

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my question. One more nit but otherwise LGTM.

@IlyaFaer IlyaFaer merged commit 2fd0025 into v4_post_policies Mar 31, 2020
@IlyaFaer
Copy link
Collaborator Author

@frankyn, moved the code into main PR.

@frankyn
Copy link

frankyn commented Mar 31, 2020

Thanks @IlyaFaer

@IlyaFaer IlyaFaer deleted the post_policy_conformance_tests branch April 1, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants