add: ws on error for unexpected http errors like 429#298
Merged
Mathieu2301 merged 1 commit intoMathieu2301:mainfrom Jun 9, 2025
Merged
add: ws on error for unexpected http errors like 429#298Mathieu2301 merged 1 commit intoMathieu2301:mainfrom
Mathieu2301 merged 1 commit intoMathieu2301:mainfrom
Conversation
Contributor
Author
|
issue #171 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds an error handler on the WebSocket client to surface unexpected HTTP errors (e.g., 429) via the existing #handleError method.
- Registers a new
'error'listener onthis.#ws - Invokes
#handleErrorwith a custom message and the error’smessageproperty
Comments suppressed due to low confidence (1)
src/client.js:269
- There’s no test covering the WebSocket
'error'event handling. Consider adding a unit or integration test to verify that#handleErroris invoked correctly when the WS emits an error.
this.#ws.on('error', (err) => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
very critical fix