MDEV-33814 Wrong error message "Can't create table" on "ALTER TABLE"

[a18792721831]

When ALTER TABLE fails (e.g., due to foreign key constraint errors),
the error message incorrectly says "Can't create table" instead of
"Can't alter table". This is because ha_create_table() is shared by
both CREATE TABLE and ALTER TABLE (copy method).

Fix: Check HA_CREATE_TMP_ALTER flag in create_info->options to
distinguish ALTER TABLE from CREATE TABLE, and use my_printf_error()
to report "Can't alter table" with the same error code (1005) for
backward compatibility.

All modified test cases pass:

• innodb.alter_table_error_message (new regression test)
• innodb.foreign_key
• innodb.fk_col_alter
• innodb.innodb-fk
• innodb.innodb-fk-warnings

[CLAassistant]

All committers have signed the CLA.

[grooverdan]

few more tests still to re-record/update.

[gkodinov]

Thank you for your contribution! This is a preliminary review.

The commit message is somewhat misleading: HA_CREATE_TMP_ALTER is not how you distinguish between ANY ALTER TABLE and CREATE TABLE: It's how you distinguish between ALTER TABLE that creates a table before it does something more with the new table and generic CREATE TABLE.

I'd rephrase a bit. Instead of:

Fix: Check HA_CREATE_TMP_ALTER flag in create_info->options to
distinguish ALTER TABLE from CREATE TABLE

I'd say:

Fix Check HA_CREATE_TMP_ALTER flag in create_info->options to
distinguish between top level CREATE TABLE and CREATE TABLE executed internally by ALTER TABLE.

[gkodinov]

there's more tests to re-record. Please check the buldbot: it must be clean

[a18792721831]

Thank you for your contribution! This is a preliminary review.

The commit message is somewhat misleading: HA_CREATE_TMP_ALTER is not how you distinguish between ANY ALTER TABLE and CREATE TABLE: It's how you distinguish between ALTER TABLE that creates a table before it does something more with the new table and generic CREATE TABLE.

I'd rephrase a bit. Instead of:

Fix: Check HA_CREATE_TMP_ALTER flag in create_info->options to
distinguish ALTER TABLE from CREATE TABLE

I'd say:

Fix Check HA_CREATE_TMP_ALTER flag in create_info->options to
distinguish between top level CREATE TABLE and CREATE TABLE executed internally by ALTER TABLE.

Thank you for the review and the correction on the commit message!

I've updated the commit message as you suggested, and also re-recorded all the affected test result files that were failing in the buildbot. The updated commit now includes changes to 22 files in total.

Please let me know if there's anything else that needs to be addressed.

[grooverdan]

Just a thought, should we add ER_CANT_ALTER_TABLE HY000 in sql/share/errmsg-utf8.txt with the same error number HY000 as ER_CANT_CREATE_TABLE so translations can be added? Then this becomes a similar looking to the else clause.