Skip to content

Removed use of asyncio.coroutines.debug_wrapper #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wallies wants to merge 3 commits into from
Closed

Removed use of asyncio.coroutines.debug_wrapper #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f885201
Removed use of asyncio.coroutines.debug_wrapper
wallies Mar 4, 2018
607d666
Fix to make uvloop/loop compile again and add conditional
wallies Mar 4, 2018
ce1bf2f
add travis to test on python 3.7-dev
wallies Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ matrix:
python: "3.6"
env: BUILD=tests

- os: linux
dist: trusty
sudo: false
language: python
python: "3.7-dev"
env: BUILD=tests

- os: linux
dist: trusty
branches: {only: [releases]}
Expand Down
43 changes: 23 additions & 20 deletions uvloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,28 +974,31 @@ cdef class Loop:
enabled = bool(enabled)
if self._coroutine_wrapper_set == enabled:
return

wrapper = aio_debug_wrapper
current_wrapper = sys_get_coroutine_wrapper()

if enabled:
if current_wrapper not in (None, wrapper):
warnings.warn(
"loop.set_debug(True): cannot set debug coroutine "
"wrapper; another wrapper is already set %r" %
current_wrapper, RuntimeWarning)
else:
sys_set_coroutine_wrapper(wrapper)
self._coroutine_wrapper_set = True

if sys_version_info >= (3, 7, 0):
pass
Copy link

@gukoff gukoff Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange. Why not if sys_version_info < (3, 7, 0)?

else:
if current_wrapper not in (None, wrapper):
warnings.warn(
"loop.set_debug(False): cannot unset debug coroutine "
"wrapper; another wrapper was set %r" %
current_wrapper, RuntimeWarning)
wrapper = aio_debug_wrapper
current_wrapper = sys_get_coroutine_wrapper()

if enabled:
if current_wrapper not in (None, wrapper):
warnings.warn(
"loop.set_debug(True): cannot set debug coroutine "
"wrapper; another wrapper is already set %r" %
current_wrapper, RuntimeWarning)
else:
sys_set_coroutine_wrapper(wrapper)
self._coroutine_wrapper_set = True
else:
sys_set_coroutine_wrapper(None)
self._coroutine_wrapper_set = False
if current_wrapper not in (None, wrapper):
warnings.warn(
"loop.set_debug(False): cannot unset debug coroutine "
"wrapper; another wrapper was set %r" %
current_wrapper, RuntimeWarning)
else:
sys_set_coroutine_wrapper(None)
self._coroutine_wrapper_set = False

cdef _create_server(self, system.sockaddr *addr,
object protocol_factory,
Expand Down