Add an option to setup coupled MALI-SLM runs in the ismip6 run testgroup#749
Conversation
|
Hi @xylar and @matthewhoffman, the PR is ready to be reviewed. The testing directory is in Chicoma (/lustre/scratch4/turquoise/hollyhan/folder_test_compass_ismip6run/landice/ismip6_run/ismip6_ais_proj2300/expAE01_04) where any Testing (done in Chicoma, with the compass conda environment The contents in the work directory look as follows: Note that in addition to |
matthewhoffman
left a comment
There was a problem hiding this comment.
@hollyhan , this is fantastic to get the SLM coupled configuration automated in compass! I have a number of requested changes, most of them small or straightforward, but there are a couple items that might require some further discussion to decide on the best solution.
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/set_up_experiment.py
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/ismip6_ais_proj2300.cfg
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/ismip6_ais_proj2300_4km_chicoma.cfg
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/ismip6_ais_proj2300_4km_nersc.cfg
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/ismip6_ais_proj2300_8km_nersc.cfg
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/namelist.sealevel.template
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/set_up_experiment.py
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/set_up_experiment.py
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/set_up_experiment.py
Outdated
Show resolved
Hide resolved
compass/landice/tests/ismip6_run/ismip6_ais_proj2300/set_up_experiment.py
Outdated
Show resolved
Hide resolved
069e697 to
1bd6701
Compare
|
@hollyhan , I've moved the mapping file generation to a new step and confirmed that mapping files are created when it is run. I still need to update the docs, but feel free to try it out and let me know if you run into any issues. One thing I realized is that all the experiments are set up as restarts from the hist run, so we will need to handle the SLM restart files somehow (or modify the experiments to not be restarts from hist). Let me know if you have thoughts about that. |
|
@hollyhan , thinking about it more, the easiest thing would be to add instructions that a user needs to manually copy the SLM output from the |
The step is only added to the test case if SLM is included in the run
Update the namelist file to reflect the changes made in the recent PR (MALI-Dev/E3SM#99) Also change the simulation end year to 2031 as required by ISMIP6-2300
3833bb3 to
9af31f7
Compare
matthewhoffman
left a comment
There was a problem hiding this comment.
@hollyhan , I updated the docs with the requirement to manually copy the OUTPUT_SLM directory from the hist run for the projection runs. With that and the changes you added today, I think all the details are taken care of. Can you update the PR description and let me know if you have any feedback on the new step I added for creating the mapping files? Once you sign off, I'm happy to have this merged.
@xylar , let me know if you wanted to take another look or are happy to consider this complete.
|
@matthewhoffman and @hollyhan, I think you should proceed. I don't think I'll have time to take another look this week and I don't want to hold things up. |
|
Thanks, @xylar . Holly said she'll take a final look today as she is setting up new runs on Chicoma. Assuming no new issues come up, I'll merge this after her thumb's up. |
|
@matthewhoffman, thanks for updating the document! I confirmed that everything looks and works great. I think it's ready to be merged! |
a9dacf7 to
4ca95ed
Compare
888c780 to
56c8b21
Compare
dbe4d4c to
6b17c26
Compare
This PR adds to the
/landice/ismip6_run/ismip_ais_proj2300testcase the option to setup coupled MALI-Sea Level Model simulations using the ismip6-Antarctica-2300 experimental protocol.With these changes, inclusion of the SLM can be activated through a test case cfg option. This will set up required namelist and input settings, as well as the namelist.sealevel file used by SLM. It will also set up an additional test case step that generates the required mapping files between MALI and SLM. This must be run before any of the experiments are run.
This PR requires addition of Pyproj string
projections['ais-bedmap2-sphere'] = '+proj=stere +lat_ts=-71.0 +lat_0=-90 +lon_0=0.0 +k_0=1.0 +x_0=0.0 +y_0=0.0 +ellps=sphere'in the MPAS-Tools scriptset_lat_lon_fields_in_planar_grid.pyto set the latitude and longitude values as if MALI was projected on sphere rather than ellipse. The requirement has been merged here (https://github.com/MPAS-Dev/MPAS-Tools/pull/559/files).