Add argument to write_netcdf for the NetCDF engine#434
Add argument to write_netcdf for the NetCDF engine#434xylar merged 2 commits intoMPAS-Dev:masterfrom
write_netcdf for the NetCDF engine#434Conversation
|
Python 3.6 testing is failing because |
Performance for the default 'netcdf4' engine has found to be poor for large files, and 'scipy' seems to perform better. For now, 'netcdf4' remains the default but the option to change is now provided. To aid in this process, default values have been defined in the mpas_tools.io module that can be modified once, rather than each time `write_netcdf` is called.
The planar_hex tool and mask creation tools have been modified to take the format and engine as arguments, so that calling code can have more control of these if needed.
xylar
force-pushed
the
select_netcdf_engine
branch
from
3b1eb9a to
164008b
Compare
TestingAs reported here MPAS-Dev/compass#187 (comment), I ran the nightly ocean test suite successfully with this branch and MPAS-Dev/compass#187 on Ubuntu with gnu and Chrysalis with intel, comparing against a baseline of the current master. The |
|
@mark-petersen and @matthewhoffman, I'm going to go ahead and merge this and make an MPAS-Tools release. You can then test these changes as part of reviewing MPAS-Dev/compass#187. It will be tricky to test both this PR and that one at the same time so I'd prefer to do it that way, since I'm pretty confident these changes are working as expected. |
1 participant
Performance for the default
netcdf4engine has found to be poor for large files on Chrysalis and Anvil, andscipyseems to perform better. For now,netcdf4remains the default but the option to change is now provided.To aid in this process, default values have been defined in the
mpas_tools.iomodule that can be modified once, rather thaneach time
write_netcdf()is called.The
planar_hextool and mask creation tools have been modified to take the format and engine as arguments, so that calling code can have more control of these if needed.