Enable MPAS to be compiled into position-independent code#307
Merged
mgduda merged 1 commit intoMPAS-Dev:developfrom Jul 10, 2019
Merged
Enable MPAS to be compiled into position-independent code#307mgduda merged 1 commit intoMPAS-Dev:developfrom
mgduda merged 1 commit intoMPAS-Dev:developfrom
Conversation
In order to allow MPAS code to be called from other systems with more flexibility, e.g., as a shared library, this commit adds a new compile option, SHAREDLIB=true, that causes all source files to be compiled with appropriate flags to generate position-independent code. The appropriate flags to use are not known for all compilers with build targets in the top-level Makefile, and if SHAREDLIB=true is specified for such a build target, an error like the following will be generated: *** Position-independent code was requested but PIC flags are not available. Please add PIC flags for the 'ftn' target. Stop.
Contributor
Author
|
This PR introduces a subset of the changes from PR #106 . |
mark-petersen
approved these changes
Jul 2, 2019
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Test merged into ocean/develop, compiled with gnu and intel, passes ocean regression test. This looks fine by inspection. I don't understand what position-independent code is, but it is protected by a flag regardless.
matthewhoffman
approved these changes
Jul 2, 2019
Member
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
Approved by inspection and @mark-petersen 's testing.
Contributor
Author
|
@mark-petersen I'm not sure this is the best explanation, but position-independent code is code that is compiled such that it makes no assumptions about the absolute locations of symbols (e.g., subroutines). Position-independent code is necessary if one wishes to create a shared library, which might be loaded anywhere in memory at run-time. As you pointed out, the changes in this PR only add additional compiler flags if |
mgduda
added a commit
that referenced
this pull request
Jul 10, 2019
This merge enables MPAS to be compiled into position-independent code. In order to allow MPAS code to be called from other systems with more flexibility, e.g., as a shared library, this commit adds a new compile option, SHAREDLIB=true, that causes all source files to be compiled with appropriate flags to generate position-independent code. The appropriate flags to use are not known for all compilers with build targets in the top-level Makefile, and if SHAREDLIB=true is specified for such a build target, an error like the following will be generated: *** Position-independent code was requested but PIC flags are not available. Please add PIC flags for the 'ftn' target. Stop. * framework/external_lib_support: Enable MPAS to be compiled into position-independent code
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…ev#307) This merge enables MPAS to be compiled into position-independent code. In order to allow MPAS code to be called from other systems with more flexibility, e.g., as a shared library, this commit adds a new compile option, SHAREDLIB=true, that causes all source files to be compiled with appropriate flags to generate position-independent code. The appropriate flags to use are not known for all compilers with build targets in the top-level Makefile, and if SHAREDLIB=true is specified for such a build target, an error like the following will be generated: *** Position-independent code was requested but PIC flags are not available. Please add PIC flags for the 'ftn' target. Stop. * framework/external_lib_support: Enable MPAS to be compiled into position-independent code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge enables MPAS to be compiled into positiion-independent code.
In order to allow MPAS code to be called from other systems with more
flexibility, e.g., as a shared library, this commit adds a new compile option,
SHAREDLIB=true, that causes all source files to be compiled with appropriateflags to generate position-independent code.
The appropriate flags to use are not known for all compilers with build
targets in the top-level Makefile, and if SHAREDLIB=true is specified for
such a build target, an error like the following will be generated: