Conversation
|
Thanks @cbrnr, please could you rebase? Not immediately clear why the tests are failing. Looks like they are failing on a style issue in a chunk of unrelated code? |
6c9e3f5 to
ceae48d
Compare
|
Done. It's because the previous pandas-related change interferred with these modifications. |
|
@bemoody Please could you add your thoughts on this PR? I see that SoundFile is explicitly pinning an upper bound ( @cbrnr Presumably the change to Black is causing the tests to fail. We need to look into what's happening there! |
|
I've fixed all Black issues, these were related to empty lines that shouldn't be there. Seems like they updated their style guide, because I noticed the same in one of my projects recently. Let me know about the |
|
@bemoody is happy |
Currently, all versions are capped, because the caret
^operator also introduces an upper bound. In this PR, I replaced^with>=, which continues to use the same lower bounds, but removes any upper bound.