Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README.md file to refresh badges, improve branding, and add a prominent citation section. The changes modernize the visual presentation and emphasize MFC's achievements in exascale computing.
Key Changes:
- Updated badge styling with new color schemes and improved test status display
- Added a prominent citation section with DOI and BibTeX entry for MFC 5.0
- Enhanced the welcome section with claims about the largest known open CFD simulation
| **Welcome!** | ||
| MFC simulates compressible multi-phase flows, [among other things](#what-else-can-this-thing-do). | ||
| It uses metaprogramming to stay short and portable (~20K lines). | ||
| MFC conducted the largest known, open CFD simulation at <a href="https://arxiv.org/abs/2505.07392" target="_blank">101 trillion grid points</a> (as of July 2025). |
There was a problem hiding this comment.
The arXiv URL (2505.07392) does not match the DOI and citation provided later in the document (2503.07953). This inconsistency should be resolved to ensure accurate referencing.
| MFC conducted the largest known, open CFD simulation at <a href="https://arxiv.org/abs/2505.07392" target="_blank">101 trillion grid points</a> (as of July 2025). | |
| MFC conducted the largest known, open CFD simulation at <a href="https://arxiv.org/abs/2503.07953" target="_blank">101 trillion grid points</a> (as of July 2025). |
| <img src="https://img.shields.io/github/stars/MFlowCode/MFC?style=flat&color=maroon"/> | ||
| </a> | ||
|
|
||
| </br> |
There was a problem hiding this comment.
Use <br> instead of </br> for line breaks in HTML. The closing tag syntax is incorrect for the self-closing br element.
| </br> | |
| <br> |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
User description
for @henryleberre
PR Type
Documentation
Description
Update README badges with improved styling and colors
Add new citation section with DOI and BibTeX
Enhance welcome message and project description
Update supercomputer references and achievements
Diagram Walkthrough
File Walkthrough
README.md
Comprehensive README enhancement with citations and stylingREADME.md