fixed bench statements

[Malmahrouqi3]

Description

Fixed print statements to be more clear that the test failed due to mainly grind time not reaching the threshold.

expected output at failure.

[Malmahrouqi3]

All failure modes: zero, negative, null, below thresholds.

 Comparing Benchmarks: Speedups from master/bench-cpu.yaml to pr/bench-cpu.yaml are displayed below. Thus, numbers > 1 represent increases in performance.
 Warning: Exec time speedup for simulation is less than 0.9 - Case: 5eq_rk3_weno3_hllc
 Error: Benchmarking failed since grind time speedup for simulation below acceptable threshold (<0.95) - Case: 5eq_rk3_weno3_hllc
 Warning: Exec time speedup for post_process is less than 0.9 - Case: 5eq_rk3_weno3_hllc
 Warning: Exec time speedup for pre_process is less than 0.9 - Case: hypo_hll
 Warning: Exec time speedup for simulation is less than 0.9 - Case: hypo_hll
 Warning: Exec time speedup for post_process is less than 0.9 - Case: hypo_hll
 Warning: Exec time speedup for pre_process is less than 0.9 - Case: viscous_weno5_sgb_acoustic
 Warning: Exec time speedup for simulation is less than 0.9 - Case: viscous_weno5_sgb_acoustic
 Error: Benchmarking failed since grind time speedup for simulation below acceptable threshold (<0.95) - Case: viscous_weno5_sgb_acoustic
 Warning: Exec time speedup for post_process is less than 0.9 - Case: viscous_weno5_sgb_acoustic
 Warning: Exec time speedup for pre_process is less than 0.9 - Case: ibm
 Warning: Exec time speedup for post_process is less than 0.9 - Case: ibm

  Case                         Pre Process                  Simulation   Post Process
 ─────────────────────────────────────────────────────────────────────────────────────
  5eq_rk3_weno3_hllc            Exec: 0.95   Exec: -0.00 & Grind: 0.00     Exec: 0.84
  hypo_hll                      Exec: 0.75                  Exec: 0.84     Exec: 0.21
  viscous_weno5_sgb_acoustic    Exec: 0.86    Exec: 0.00 & Grind: 0.00     Exec: 0.77
  ibm                           Exec: 0.68                         N/A     Exec: 0.63



Error: Benchmarking failed

Terminated

[sbryngelson]

will merge once the benchmark CI passes

[Malmahrouqi3]

sounds good

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.78%. Comparing base (59d0c09) to head (170cbe6).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   45.78%   45.78%           
=======================================
  Files          68       68           
  Lines       18658    18658           
  Branches     2251     2251           
=======================================
  Hits         8543     8543           
  Misses       8757     8757           
  Partials     1358     1358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Malmahrouqi3]

Benchmark / Phoenix gpu failed to build master oddly.

[Malmahrouqi3]

Genuinely baffling, I can't see what could have triggered the failure. I will submit a manual benchmark job on Phoenix right now and share the results tonight.

[sbryngelson]

Phoenix is having filesystem migration issues.

asdf