Fixed Examples, Added Examples CI.#664
Merged
sbryngelson merged 100 commits intoMFlowCode:masterfrom Dec 3, 2024
Merged
Conversation
…1 on examples, fixed m_patches typo. todo: fix 1D bubble cases
Member
|
Can be merged once CI passes + merge conflicts resolved. |
Co-authored-by: Spencer Bryngelson <sbryngelson@gmail.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduced Example Test cases and added to CI
Fixed examples
Fixed bugs breaking some of the examples
Currently skips these examples:
["2D_ibm_cfl_dt", "1D_sodHypo", "2D_viscous", "2D_laplace_pressure_jump", "2D_bubbly_steady_shock", "2D_advection", "2D_hardcodied_ic", "2D_ibm_multiphase"]
Fixes #474
To-do
Type of change
Scope
How Has This Been Tested?
Test Configuration:
Checklist
./mfc.sh formatbefore committing my code