Add Python 3.13 setup step to test workflow#1016
Add Python 3.13 setup step to test workflow#1016sbryngelson merged 1 commit intoMFlowCode:masterfrom
Conversation
Added step to set up Python 3.13 in the workflow.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Python 3.13 setup step to the GitHub Actions test workflow to fix compatibility issues with Cantera on macOS, which was being forced to use Python 3.14.
Key Changes
- Added Python 3.13 setup step to the test workflow before OS-specific setup steps
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
| - name: Clone | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python 3.13 | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.13' | ||
|
|
||
| - name: Setup MacOS | ||
| if: matrix.os == 'macos' |
There was a problem hiding this comment.
Suggestion: Instead of hardcoding the Python version to '3.13', use the matrix.python-version variable in the setup-python step. This ensures each job in the matrix uses its designated Python version. [possible issue, importance: 8]
| - name: Clone | |
| uses: actions/checkout@v4 | |
| - name: Set up Python 3.13 | |
| uses: actions/setup-python@v5 | |
| with: | |
| python-version: '3.13' | |
| - name: Setup MacOS | |
| if: matrix.os == 'macos' | |
| - name: Clone | |
| uses: actions/checkout@v4 | |
| - name: Set up Python ${{ matrix.python-version }} | |
| uses: actions/setup-python@v5 | |
| with: | |
| python-version: ${{ matrix.python-version }} | |
| - name: Setup MacOS | |
| if: matrix.os == 'macos' |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1016 +/- ##
=======================================
Coverage 41.75% 41.75%
=======================================
Files 70 70
Lines 20126 20126
Branches 2504 2504
=======================================
Hits 8403 8403
Misses 10180 10180
Partials 1543 1543 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
Fixes Cantera forced by macos loading python 3.14, revert to 3.13
PR Type
Other
Description
Add Python 3.13 setup step to GitHub Actions workflow
Fix Cantera compatibility issue with macOS Python version
Diagram Walkthrough
File Walkthrough
test.yml
Add Python 3.13 setup step.github/workflows/test.yml