Skip to content

Add Python 3.13 setup step to test workflow#1016

Merged
sbryngelson merged 1 commit intoMFlowCode:masterfrom
sbryngelson:fix-cantera
Oct 12, 2025
Merged

Add Python 3.13 setup step to test workflow#1016
sbryngelson merged 1 commit intoMFlowCode:masterfrom
sbryngelson:fix-cantera

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Oct 11, 2025

User description

Fixes Cantera forced by macos loading python 3.14, revert to 3.13


PR Type

Other


Description

  • Add Python 3.13 setup step to GitHub Actions workflow

  • Fix Cantera compatibility issue with macOS Python version


Diagram Walkthrough

flowchart LR
  A["GitHub Actions Workflow"] --> B["Python 3.13 Setup Step"] --> C["MacOS Setup Step"]
Loading

File Walkthrough

Relevant files
Configuration changes
test.yml
Add Python 3.13 setup step                                                             

.github/workflows/test.yml

  • Added Python 3.13 setup step using actions/setup-python@v5
  • Positioned before existing MacOS setup step
+5/-0     

Added step to set up Python 3.13 in the workflow.
Copilot AI review requested due to automatic review settings October 11, 2025 21:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Python 3.13 setup step to the GitHub Actions test workflow to fix compatibility issues with Cantera on macOS, which was being forced to use Python 3.14.

Key Changes

  • Added Python 3.13 setup step to the test workflow before OS-specific setup steps

@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

Using actions/setup-python on all OSes may override the runner's default Python and conflict with OS-specific setup, especially for non-macos jobs if only macOS needed 3.13. Confirm matrix and conditionally apply Python setup only where required.

- name: Set up Python 3.13
  uses: actions/setup-python@v5
  with:
    python-version: '3.13'
Order Dependency

Python setup occurs before the macOS setup step which runs brew update; if brew or macOS setup installs or selects a different Python, it may undo the 3.13 selection. Validate that PATH and version remain 3.13 after macOS setup, or pin/rehash after.

- name: Set up Python 3.13
  uses: actions/setup-python@v5
  with:
    python-version: '3.13'

- name: Setup MacOS
  if:   matrix.os == 'macos'
  run:  |
    brew update

Comment on lines 48 to 57
- name: Clone
uses: actions/checkout@v4

- name: Set up Python 3.13
uses: actions/setup-python@v5
with:
python-version: '3.13'

- name: Setup MacOS
if: matrix.os == 'macos'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Instead of hardcoding the Python version to '3.13', use the matrix.python-version variable in the setup-python step. This ensures each job in the matrix uses its designated Python version. [possible issue, importance: 8]

Suggested change
- name: Clone
uses: actions/checkout@v4
- name: Set up Python 3.13
uses: actions/setup-python@v5
with:
python-version: '3.13'
- name: Setup MacOS
if: matrix.os == 'macos'
- name: Clone
uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Setup MacOS
if: matrix.os == 'macos'

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.75%. Comparing base (c86fdd9) to head (7768928).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1016   +/-   ##
=======================================
  Coverage   41.75%   41.75%           
=======================================
  Files          70       70           
  Lines       20126    20126           
  Branches     2504     2504           
=======================================
  Hits         8403     8403           
  Misses      10180    10180           
  Partials     1543     1543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson enabled auto-merge (squash) October 12, 2025 00:31
@sbryngelson sbryngelson disabled auto-merge October 12, 2025 00:31
@sbryngelson sbryngelson merged commit 1fbaaf8 into MFlowCode:master Oct 12, 2025
28 of 31 checks passed
@sbryngelson sbryngelson deleted the fix-cantera branch November 1, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants