Skip to content

delete m_eigen_solver#1000

Merged
sbryngelson merged 1 commit intoMFlowCode:masterfrom
hyeoksu-lee:rmv_eigensolver
Sep 19, 2025
Merged

delete m_eigen_solver#1000
sbryngelson merged 1 commit intoMFlowCode:masterfrom
hyeoksu-lee:rmv_eigensolver

Conversation

@hyeoksu-lee
Copy link
Contributor

@hyeoksu-lee hyeoksu-lee commented Sep 18, 2025

User description

Description

Delete m_eigen_solver as it is replaced by LAPACK and no longer used.

Type of change

Please delete options that are not relevant.

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Test suite passed on MacBook M4 Pro


PR Type

Other


Description

  • Remove entire m_eigen_solver module (815 lines)

  • Delete EISPACK-based eigenvalue solver implementation

  • Clean up deprecated complex matrix eigenvalue routines


Diagram Walkthrough

flowchart LR
  A["m_eigen_solver.f90"] -- "delete" --> B["removed"]
  C["EISPACK routines"] -- "replaced by" --> D["LAPACK"]
Loading

File Walkthrough

Relevant files
Miscellaneous
m_eigen_solver.f90
Delete entire eigenvalue solver module                                     

src/common/m_eigen_solver.f90

  • Complete removal of the entire file (815 lines deleted)
  • Eliminates EISPACK-based eigenvalue solver routines
  • Removes complex matrix eigenvalue computation functions
  • Deletes helper routines for matrix balancing and transformations
+0/-815 

@hyeoksu-lee hyeoksu-lee requested a review from a team September 18, 2025 18:23
@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.91%. Comparing base (e966781) to head (1ac96d1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
+ Coverage   40.91%   41.91%   +1.00%     
==========================================
  Files          70       69       -1     
  Lines       20270    19783     -487     
  Branches     2520     2473      -47     
==========================================
  Hits         8293     8293              
+ Misses      10439     9952     -487     
  Partials     1538     1538              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson merged commit eb61616 into MFlowCode:master Sep 19, 2025
33 checks passed
@hyeoksu-lee hyeoksu-lee deleted the rmv_eigensolver branch October 6, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants