Add warning when user attempts to edit basal schedule without a configured pump#1290
Merged
ps2 merged 2 commits intoLoopKit:devfrom Apr 1, 2020
Merged
Add warning when user attempts to edit basal schedule without a configured pump#1290ps2 merged 2 commits intoLoopKit:devfrom
ps2 merged 2 commits intoLoopKit:devfrom
Conversation
mitchellhenke
pushed a commit
to mitchellhenke/Loop
that referenced
this pull request
Apr 12, 2020
…gured pump (LoopKit#1290) * Add alert for unconfigured pump * Fix ordering
mitchellhenke
pushed a commit
to mitchellhenke/Loop
that referenced
this pull request
Apr 12, 2020
…gured pump (LoopKit#1290) * Add alert for unconfigured pump * Fix ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Loop doesn't display any message when the user attempts to edit the basal schedule without a configured pump, which can be confusing to new users. This is just a simple UIAlert that displays when the row is tapped without a configured pump; completely open to changing the wording to make it better.