Fix nightscout uploading trend arrow inconsistency#1274
Merged
ps2 merged 1 commit intoLoopKit:devfrom Feb 25, 2020
dabear:dev+nsfix
Merged
Fix nightscout uploading trend arrow inconsistency#1274ps2 merged 1 commit intoLoopKit:devfrom dabear:dev+nsfix
ps2 merged 1 commit intoLoopKit:devfrom
dabear:dev+nsfix
Conversation
Contributor
Author
|
On the nightscout repo, see which trend arrows are supported here: https://github.com/nightscout/cgm-remote-monitor/blob/7c272ec67a7795e0f4edf7ff9abdfac1bd1308a0/tests/direction.test.js#L69 |
Contributor
Author
|
@ps2 this is a small change. Tested successfully. Should be ready to merge |
mitchellhenke
pushed a commit
to mitchellhenke/Loop
that referenced
this pull request
Apr 12, 2020
mitchellhenke
pushed a commit
to mitchellhenke/Loop
that referenced
this pull request
Apr 12, 2020
|
We have Loop Master Branch 2.0. We started looping in March and have not added any features or changed branches. We have Loop Master 2.0/Ominpod/Dexcom G6/iPhone 11 Pro iOS 13.4.1. I am not a technical person and make a very honest effort to watch Kate's Youtube videos and search groups to find information as well as other FB groups that post helpful videos. The learning curve is steep but I am determined. I would greatly appreciate input or direction! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reported on zulipchat: https://loop.zulipchat.com/#narrow/stream/144182-development/topic/trend.20arrow.20inconsistency
The code for uploading to nightscout has been inside Loop for a very long time, but has up to now only been used by the medtronic enlite cgmmanager. Now that the Dexcom cgmmanager also can upload to loop, more users have started using this feature.
I've detected that the loop trend arrow doesn't always match the trend arrow displayed in nightscout. This fixes that by uploading the correct trend arrow names, adding those that were lacking from the original implementation.
(My guess is that Loop's code for uploading glucose trend arrows predates nightscout's support for granular trend arrows. This code should be safe because Nightscout users generally update fast and because nightscout has supported granular trend arrows for a long time now, meaning the risk here is quite low.)